Revert symfony rules applied to own source

Keep console command metadata in configure() and skip
CommandConfigureToAttributeRector, so the set only affects
downstream projects.

Author: TomasVotruba

rector.php

@@ -9,6 +9,7 @@
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRector;
 use Rector\Symfony\Symfony44\Rector\ClassMethod\ConsoleExecuteReturnIntRector;
+use Rector\Symfony\Symfony61\Rector\Class_\CommandConfigureToAttributeRector;
 
 return RectorConfig::configure()
     ->withPreparedSets(
@@ -45,6 +46,9 @@
 
         // adds (int) cast to methods that already return int, ping-pongs with RecastingRemovalRector
         ConsoleExecuteReturnIntRector::class,
+
+        // keep console command metadata in configure(), as more readable than a single long attribute
+        CommandConfigureToAttributeRector::class,
         // tests
         '*/Fixture*',
         '*/Source*',

src/Console/Command/ComposerBasedCommand.php

@@ -13,7 +13,6 @@
 use Rector\VersionBonding\Contract\ComposerPackageConstraintInterface;
 use Rector\VersionBonding\ValueObject\ComposerBoundRuleConfiguration;
 use ReflectionObject;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\TableCell;
 use Symfony\Component\Console\Helper\TableSeparator;
@@ -24,7 +23,6 @@
 /**
  * @see \Rector\Tests\Console\Command\ComposerBasedCommandTest
  */
-#[AsCommand(name: 'composer-based', description: 'Show loaded rules that are triggered by an installed composer package version')]
 final class ComposerBasedCommand extends Command
 {
     /**
@@ -38,6 +36,12 @@ public function __construct(
         parent::__construct();
     }
 
+    protected function configure(): void
+    {
+        $this->setName('composer-based');
+        $this->setDescription('Show loaded rules that are triggered by an installed composer package version');
+    }
+
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $tableRows = $this->createTableRows();

src/Console/Command/CustomRuleCommand.php

@@ -10,15 +10,13 @@
 use Rector\Enum\ClassName;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\FileSystem\JsonFileSystem;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Finder\SplFileInfo;
 
-#[AsCommand(name: 'custom-rule', description: 'Create base of local custom rule with tests')]
 final class CustomRuleCommand extends Command
 {
     public function __construct(
@@ -28,6 +26,12 @@ public function __construct(
         parent::__construct();
     }
 
+    protected function configure(): void
+    {
+        $this->setName('custom-rule');
+        $this->setDescription('Create base of local custom rule with tests');
+    }
+
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         // ask for rule name

src/Console/Command/ListRulesCommand.php

@@ -10,14 +10,12 @@
 use Rector\Contract\Rector\RectorInterface;
 use Rector\PostRector\Contract\Rector\PostRectorInterface;
 use Rector\Skipper\SkipCriteriaResolver\SkippedClassResolver;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
-#[AsCommand(name: 'list-rules', description: 'Show loaded Rectors', aliases: ['show-rules'])]
 final class ListRulesCommand extends Command
 {
     /**
@@ -33,6 +31,11 @@ public function __construct(
 
     protected function configure(): void
     {
+        $this->setName('list-rules');
+        $this->setDescription('Show loaded Rectors');
+
+        $this->setAliases(['show-rules']);
+
         $this->addOption(
             Option::OUTPUT_FORMAT,
             null,

src/Console/Command/ProcessCommand.php

@@ -26,13 +26,11 @@
 use Rector\ValueObject\Configuration\LevelOverflow;
 use Rector\ValueObject\ProcessResult;
 use Symfony\Component\Console\Application;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
-#[AsCommand(name: 'process', description: 'Upgrades or refactors source code with provided Rector rules', aliases: ['p'])]
 final class ProcessCommand extends Command
 {
     public function __construct(
@@ -55,6 +53,9 @@ public function __construct(
 
     protected function configure(): void
     {
+        $this->setName('process');
+        $this->setAliases(['p']);
+        $this->setDescription('Upgrades or refactors source code with provided Rector rules');
         $this->setHelp(
             <<<'EOF'
 The <info>%command.name%</info> command will run Rector main feature:

src/Console/Command/SetupCICommand.php

@@ -7,14 +7,12 @@
 use Nette\Utils\FileSystem;
 use OndraM\CiDetector\CiDetector;
 use Rector\Git\RepositoryHelper;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use function sprintf;
 
-#[AsCommand(name: 'setup-ci', description: 'Add CI workflow to let Rector work for you')]
 final class SetupCICommand extends Command
 {
     public function __construct(
@@ -23,6 +21,12 @@ public function __construct(
         parent::__construct();
     }
 
+    protected function configure(): void
+    {
+        $this->setName('setup-ci');
+        $this->setDescription('Add CI workflow to let Rector work for you');
+    }
+
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         // detect current CI

src/Console/Command/WorkerCommand.php

@@ -20,7 +20,6 @@
 use Rector\Util\MemoryLimiter;
 use Rector\ValueObject\Configuration;
 use Rector\ValueObject\Error\SystemError;
-use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -37,7 +36,6 @@
  * ↓↓↓
  * https://github.com/phpstan/phpstan-src/commit/b84acd2e3eadf66189a64fdbc6dd18ff76323f67#diff-7f625777f1ce5384046df08abffd6c911cfbb1cfc8fcb2bdeaf78f337689e3e2
  */
-#[AsCommand(name: 'worker', description: '[INTERNAL] Support for parallel process')]
 final class WorkerCommand extends Command
 {
     private const string RESULT = 'result';
@@ -55,6 +53,9 @@ public function __construct(
 
     protected function configure(): void
     {
+        $this->setName('worker');
+        $this->setDescription('[INTERNAL] Support for parallel process');
+
         ProcessConfigureDecorator::decorate($this);
 
         parent::configure();