Skip to content

Commit fe529b4

Browse files
committed
[perf] Short-circuit node classes with no subscribed rules in traverser
1 parent 503127a commit fe529b4

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎scripts/validate-node-rule-map.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
// keep only core rules from the committed map
3939
$committedCoreMap = [];
4040
foreach ($committedMap as $nodeClass => $ruleClasses) {
41-
$coreRuleClasses = array_filter($ruleClasses, static fn(string $ruleClass): bool => array_all($siblingNamespacePrefixes, fn(string $siblingNamespacePrefix): bool => !str_starts_with($ruleClass, $siblingNamespacePrefix)));
41+
$coreRuleClasses = array_filter($ruleClasses, static fn (string $ruleClass): bool => array_all($siblingNamespacePrefixes, fn (string $siblingNamespacePrefix): bool => ! str_starts_with($ruleClass, $siblingNamespacePrefix)));
4242

4343
$committedCoreMap[$nodeClass] = array_values($coreRuleClasses);
4444
}

‎src/PhpParser/NodeTraverser/RectorNodeTraverser.php‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,11 @@ public function getVisitorsForNode(Node $node): array
145145
$visitorsByPosition = [];
146146

147147
if (array_key_exists($nodeClass, $this->nodeRuleMap)) {
148+
// no rule subscribes to this node class and no third-party rules to check
149+
if ($this->nodeRuleMap[$nodeClass] === [] && $this->unknownVisitors === []) {
150+
return $this->visitorsPerNodeClass[$nodeClass] = [];
151+
}
152+
148153
// O(1) lookup in the static map, then keep only the active rules
149154
foreach ($this->nodeRuleMap[$nodeClass] as $ruleClass) {
150155
if (isset($this->visitorByClass[$ruleClass])) {

0 commit comments

Comments
 (0)