[Php85] Skip outer spread on NestedFuncCallsToPipeOperatorRector (#8191)

* [Php85] Skip outer spread on NestedFuncCallsToPipeOperatorRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/skip_outer_spread_nested_call.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;
+
+final class SkipOuterSpreadNestedCall
+{
+    public function flatten(array $groups): array
+    {
+        return array_merge(...array_values($groups));
+    }
+}

rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php

@@ -492,12 +492,11 @@ private function shouldUsePropertyTypeForPromotedParam(Property $property, Param
             $paramType = TypeCombinator::union($paramType, $this->getType($param->default));
         }
 
-        if ($this->typeComparator->isSubtype($paramType, $propertyType)
-            && ! $this->typeComparator->areTypesEqual($propertyType, $paramType)) {
-            return false;
+        if (!$this->typeComparator->isSubtype($paramType, $propertyType)) {
+            return true;
         }
 
-        return true;
+        return $this->typeComparator->areTypesEqual($propertyType, $paramType);
     }
 
     private function shouldSkipPropertyAssignedNull(Class_ $class, string $propertyName): bool

rules/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector.php

@@ -139,17 +139,17 @@ private function processNestedCalls(Expr $expr, bool $deep = false): ?Expr
                 return null;
             }
 
+            // Spread argument can't be converted to pipe — keep the call as-is
+            if ($arg->unpack) {
+                return null;
+            }
+
             if ($arg->value instanceof FuncCall) {
                 return $this->buildPipeExpression($expr, $arg->value);
             }
 
             // If we're deep in recursion and hit a non-FuncCall, this is the base
             if ($deep) {
-                // Spread argument can't be converted to pipe — keep the call as-is
-                if ($arg->unpack) {
-                    return null;
-                }
-
                 // Return a pipe with the base expression on the left
                 return new Pipe($arg->value, $this->createPlaceholderCall($expr));
             }