Skip to content

[static-analysis] Replace tomasvotruba/unused-public with shipmonk/dead-code-detector - #8530

Merged
TomasVotruba merged 5 commits into
mainfrom
replace-unused-public-with-dead-code-detector
Oct 10, 2026
Merged

TomasVotruba merged 5 commits into
mainfrom
replace-unused-public-with-dead-code-detector

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Swaps the dev dependency tomasvotruba/unused-public for shipmonk/dead-code-detector (^1.4), which detects unused methods, properties and constants.

Changes:

  • composer.json: drop tomasvotruba/unused-public, add shipmonk/dead-code-detector (auto-registered via extension-installer).
  • phpstan.neon: remove the unused_public block; set shipmonkDeadCode.cache.offloadCollectorData: false so cold-cache parallel runs do not crash with a missing DCD cache file.
  • phpstan-baseline-dead-code.neon: baseline for the 11 initial findings, left for a follow-up cleanup. These include known false positives - the dynamically dispatched BetterStandardPrinter::p* printer methods and contract interface methods.

CI (composer complete-check) passes locally: phpstan level 8 green on a cold cache, ECS clean.

@TomasVotruba
TomasVotruba force-pushed the replace-unused-public-with-dead-code-detector branch 3 times, most recently from e8e19ae to 47100f4 Compare October 10, 2026 09:24
@TomasVotruba TomasVotruba changed the title Replace tomasvotruba/unused-public with shipmonk/dead-code-detector [static-analysis] Replace tomasvotruba/unused-public with shipmonk/dead-code-detector Oct 10, 2026
@TomasVotruba
TomasVotruba force-pushed the replace-unused-public-with-dead-code-detector branch from 808350c to 379b989 Compare October 10, 2026 09:26
@TomasVotruba
TomasVotruba force-pushed the replace-unused-public-with-dead-code-detector branch from 09a3a7e to 31fffee Compare October 10, 2026 09:27
@TomasVotruba
TomasVotruba enabled auto-merge (squash) October 10, 2026 09:28
@TomasVotruba
TomasVotruba merged commit 672d7fb into main Oct 10, 2026
49 checks passed
@TomasVotruba
TomasVotruba deleted the replace-unused-public-with-dead-code-detector branch October 10, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant