Repository navigation
Resolve class reflection lazily in property promotion rename - #8546
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
IssueConstructorPromotionRenameTest.When
ClassPropertyAssignToConstructorPromotionRectorruns beforeRenamePropertyToMatchTypeRector, it rewrites the class node. The new node has no scope attribute, soPropertyPromotionRenamerbailed out early onresolveClassReflection()(scope-based) and the rename never fired.The class reflection is only used for the trait-usage check. Now it is resolved only when the class actually has trait uses, so the common no-trait case no longer depends on scope. Trait classes keep the same check.