Repository navigation
[Naming] Deprecate RenameForeachValueVariableToMatchExprVariableRector - #8548
Merged
TomasVotruba merged 1 commit intoOct 8, 2026
Merged
Conversation
TomasVotruba
force-pushed
the
deprecate-rename-foreach-value-to-expr-variable
branch
from
October 8, 2026 19:42
3751658 to
e267947
Compare
TomasVotruba
force-pushed
the
deprecate-rename-foreach-value-to-expr-variable
branch
from
October 8, 2026 19:46
e267947 to
f511342
Compare
TomasVotruba
enabled auto-merge (squash)
October 8, 2026 19:46
TomasVotruba
deleted the
deprecate-rename-foreach-value-to-expr-variable
branch
October 8, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
RenameForeachValueVariableToMatchExprVariableRector.Renaming a foreach value variable to match the iterated expression variable is risky - it can clobber meaningful local names and cause conflicts, while offering little real value. The rule now implements
DeprecatedInterfaceand throws onrefactor(), mirroring the existing deprecation pattern.Changes:
getRuleDefinition()andgetNodeTypes())config/set/naming.phprules-tests/directoryCascade cleanup (orphaned by the removal, only consumer was this rule):
Rector\Naming\ExpectedNameResolver\InflectorSingularResolverand its test