Repository navigation
[Naming] Deprecate RenameVariableToMatchMethodCallReturnTypeRector - #8549
Merged
TomasVotruba merged 1 commit intoOct 8, 2026
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
October 8, 2026 19:29
TomasVotruba
force-pushed
the
deprecate-rename-variable-to-method-call-return-type
branch
from
October 8, 2026 19:40
34130cb to
e123094
Compare
TomasVotruba
force-pushed
the
deprecate-rename-variable-to-method-call-return-type
branch
from
October 8, 2026 19:43
e123094 to
b2d1979
Compare
TomasVotruba
deleted the
deprecate-rename-variable-to-method-call-return-type
branch
October 8, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
RenameVariableToMatchMethodCallReturnTypeRector.Renaming a variable to match a method call return type is risky - it can clobber meaningful, intentional local names and cause conflicts, while the existing name usually carries more context than the callee type.
The rule now implements
DeprecatedInterfaceand throws onrefactor(), keeping onlygetRuleDefinition()andgetNodeTypes().Cleanup of now-orphaned internals used only by this rule:
Rector\Naming\Matcher\VariableAndCallAssignMatcherRector\Naming\ValueObject\VariableAndCallAssignExpectedNameResolver::resolveForCall()CallMatcher::matchCall()param toForeach_(only remaining caller type)Unregistered from
config/set/naming.phpand removed from theIssue7112combination config (keptAddVoidReturnTypeWhereNoReturnRector). Rule tests removed.