Repository navigation
[Naming] Deprecate RenameForeachValueVariableToMatchMethodCallReturnTypeRector - #8550
Merged
TomasVotruba merged 2 commits intoOct 8, 2026
Merged
TomasVotruba merged 2 commits into
TomasVotruba merged 2 commits into
Conversation
TomasVotruba
deleted the
deprecate-rename-foreach-value-to-method-call-return-type
branch
October 8, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
RenameForeachValueVariableToMatchMethodCallReturnTypeRector.Renaming a foreach value variable to match the method-call return type is risky - it can clobber meaningful local variable names and introduce naming conflicts. The original variable name often carries more context than the callee return type, so the rename tends to reduce readability rather than improve it.
The rule now implements
DeprecatedInterfaceand throws fromrefactor(), following the existing deprecation pattern (seeSwitchNegatedTernaryRector). It is unregistered from thenamingset and its tests are removed.Cascade cleanup of services left orphaned by the removal:
Rector\Naming\Matcher\ForeachMatcher- deleted (sole user)Rector\Naming\ValueObject\VariableAndCallForeach- deleted (sole user)Rector\Naming\RectorNamingInflector- deleted (only fed the removed singularized name)ExpectedNameResolver::resolveForForeach()and its private helpers - removedExpectedName::getSingularized()/isSingular()and thesingularizedproperty - removed, as only the foreach path consumed themCallMatcher::matchCall()param narrowed toAssign(the only remaining caller)