Repository navigation
[Php80] Drop import-adding from NestedAnnotationToAttributeRector - #8561
Merged
Merged
Conversation
…it FQN in factory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule reached into
$this->file->getFileNode()->getPendingImports()via acompleteExtraUseImports()method to register ausefor the nested attribute class. Adding imports from inside a rule crosses the layer that the PostRector/NameImporter path owns.Instead,
PhpNestedAttributeGroupFactorynow emits aFullyQualifiedattribute name when a new import is needed, so the standard name-importing path handles it whenimportNamesis on, and the output stays valid FQN otherwise. No rule-level import manipulation remains.Removed along with the method: the now-unused
AttributeKey::EXTRA_USE_IMPORTconstant.