Repository navigation
Skip skip-probe deep clone unless unused-skip reporting is on - #8563
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
TomasVotruba
force-pushed
the
tv-drop-clonenode-skip-probe
branch
from
October 9, 2026 13:51
07bcd81 to
3aa3f90
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-drop-clonenode-skip-probe
branch
from
October 9, 2026 13:54
3aa3f90 to
52da11c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class/path skip-probe deep-cloned the node, ran the rule on the clone, and marked the skip used if it would have changed something. That result only feeds the unused-skips report, which is off by default (UnusedSkipResolver::shouldSkipReporting).
So on a normal run the deep clone was pure overhead - its result was thrown away. This gates the probe behind Option::REPORT_UNUSED_SKIPS:
First attempt dropped the clone entirely and probed the real node, but that mutated skipped nodes and broke skip tests - the clone is load-bearing when reporting is on.