Skip to content

Call the TypeTraverser callback with one argument #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 9, 2026
Merged

Call the TypeTraverser callback with one argument #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rules/Privatization/TypeManipulator/TypeNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function generalizeConstantTypes(Type $type): Type
}

// should be string[]
$itemType = $traverseCallback($type->getItemType(), $traverseCallback);
$itemType = $traverseCallback($type->getItemType());

if ($itemType instanceof ConstantStringType) {
$itemType = new StringType();
Expand Down Expand Up @@ -159,7 +159,7 @@ public function generalizeConstantTypes(Type $type): Type
return $uniqueGeneralizedUnionTypes[0];
}

$convertedType = $traverseCallback($type, $traverseCallback);
$convertedType = $traverseCallback($type);
if ($convertedType instanceof NeverType) {
return new MixedType();
}
Expand Down Expand Up @@ -236,7 +236,7 @@ private function resolveNameShortDocTypeNode(UnionType $unionType): TypeNode
return new ShortenedObjectType($shortClassName, $type->getClassName());
}

return $traverseCallback($type, $traverseCallback);
return $traverseCallback($type);
});

return $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($objectShortGeneralizedUnionType);
Expand Down
4 changes: 2 additions & 2 deletions src/PHPStanStaticTypeMapper/TypeMapper/ObjectTypeMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ public function mapToPHPStanPhpDocTypeNode(Type $type): TypeNode
}

if ($type instanceof GenericObjectType) {
return $traverse(new GenericObjectType('\\' . $type->getClassName(), $type->getTypes()), $traverse);
return $traverse(new GenericObjectType('\\' . $type->getClassName(), $type->getTypes()));
}

return $traverse($type, $traverse);
return $traverse($type);
});

return $type->toPhpDocNode();
Expand Down
Loading