From 96280902e2e951ae9d217f207dd925fda4fb56dc Mon Sep 17 00:00:00 2001 From: Sander Muller Date: Fri, 9 Oct 2026 15:58:26 +0200 Subject: [PATCH 1/2] Report unmatched PHPStan ignores and remove the stale ones --- phpstan.neon | 46 ---------------------------------------------- 1 file changed, 46 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index 818693e2edd..a399bc8ef9c 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -7,7 +7,6 @@ rules: parameters: level: 8 - reportUnmatchedIgnoredErrors: false errorFormat: symplify # see https://phpstan.org/writing-php-code/phpdoc-types#global-type-aliases @@ -65,11 +64,6 @@ parameters: constants: true ignoreErrors: - # keepComments() is a generic helper; do not narrow it after the deprecated CombineIfRector stopped calling it - - - identifier: typePerfect.narrowPublicClassMethodParamType - path: src/BetterPhpDocParser/Comment/CommentsMerger.php - # the deprecated set objects are still resolved internally, until every extension bonds its rules - message: '#deprecated (class|interface) Rector\\(Set|Bridge)\\#' @@ -125,11 +119,6 @@ parameters: message: '#Parameter \#1 \$items of class PhpParser\\Node\\Expr\\Array_ constructor expects array, array given#' path: rules/Php71/Rector/List_/ListToArrayDestructRector.php - - - identifier: argument.type - message: '#Parameter \#3 \$assign of method Rector\\CodeQuality\\Rector\\FunctionLike\\SimplifyUselessVariableRector\:\:processSimplifyUselessVariable\(\) expects PhpParser\\Node\\Expr\\Assign\|PhpParser\\Node\\Expr\\AssignOp, PhpParser\\Node\\Expr given#' - path: rules/CodeQuality/Rector/FunctionLike/SimplifyUselessVariableRector.php - # scope vs mutating scope - identifier: argument.type @@ -148,10 +137,6 @@ parameters: - rules/TypeDeclarationDocblocks/Rector/Class_/AddVarArrayDocblockFromDimFetchAssignRector.php - src/NodeTypeResolver/PHPStan/Type/TypeFactory.php - - - identifier: arguments.count - message: '#Callable callable\(PHPStan\\Type\\Type\)\: PHPStan\\Type\\Type invoked with 2 parameters, 1 required#' - # classes are part of *.php.inc fixture - identifier: class.notFound @@ -345,32 +330,6 @@ parameters: paths: - src/Skipper/SkipCriteriaResolver/SkippedClassResolver.php - # native filesystem calls, required for performance reasons - - - identifier: symplify.forbiddenNode - message: '#@(.*?) is forbidden to use#' - path: src/Caching/ValueObject/Storage/FileCacheStorage.php - - - - identifier: symplify.forbiddenNode - message: '#@\\ini_set\(.*\)" is forbidden to use#' - path: bin/rector.php - - - - message: '#PHPDoc tag @var with type array is not subtype of native type array#' - path: src/Bootstrap/ExtensionConfigResolver.php - - - - identifier: symplify.forbiddenStaticClassConstFetch - message: '#Avoid static access of constants, as they can change value\. Use interface and contract method instead#' - paths: - - src/PostRector/Rector/AbstractPostRector.php - - src/Testing/PHPUnit/AbstractRectorTestCase.php - - - - identifier: symplify.forbiddenStaticClassConstFetch - path: src/Rector/AbstractRector.php - - identifier: symplify.noConstructorOverride path: src/StaticTypeMapper/ValueObject/Type/SimpleStaticType.php @@ -413,11 +372,6 @@ parameters: path: src/PhpParser/Parser/RectorParser.php # known types - - - identifier: varTag.nativeType - message: '#PHPDoc tag @var with type array is not subtype of native type array>#' - path: rules/Naming/PhpArray/ArrayFilter.php - - identifier: varTag.nativeType path: src/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php From 398e03e2f023de259db0c27844cc3690619c4e53 Mon Sep 17 00:00:00 2001 From: Sander Muller Date: Fri, 9 Oct 2026 16:45:22 +0200 Subject: [PATCH 2/2] Keep reportUnmatchedIgnoredErrors disabled for now --- phpstan.neon | 1 + 1 file changed, 1 insertion(+) diff --git a/phpstan.neon b/phpstan.neon index a399bc8ef9c..0081acb6394 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -7,6 +7,7 @@ rules: parameters: level: 8 + reportUnmatchedIgnoredErrors: false errorFormat: symplify # see https://phpstan.org/writing-php-code/phpdoc-types#global-type-aliases