Repository navigation
[TypeDeclaration] Deprecate ParamTypeByMethodCallTypeRector and its split Object/Scalar/Array rules - #8567
Merged
Conversation
…plit Object/Scalar/Array rules
TomasVotruba
force-pushed
the
tv-deprecate-param-type-by-method-call
branch
from
October 9, 2026 17:33
4b26eb2 to
b9e3367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ParamTypeByMethodCallTypeRectorand the Object/Scalar/Array rules split out of it in #8134.These rules infer a param type from a single caller argument and fill it in as a native type. That is risky: it can fill invalid types and cause type errors on controllers and other input-call methods, where the real accepted type is wider than one observed caller. Inferring types this way is unreliable and needs human verification, so it better suits static analysis than an automated code change.
Each rule now implements
DeprecatedInterface, itsrefactor()throws with a deprecation message, and all four are removed from the TypeDeclaration level. Tests and the shared engine body are dropped.