Repository navigation
Restore intentional @ forbiddenNode ignores, enable reportUnmatchedIgnoredErrors - #8569
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
Member
Author
|
Closing: this applied the stale-ignore cleanup and reportUnmatchedIgnoredErrors on a main base with the old symplify/phpstan-rules deps, where those ignores still match (and the restored forbiddenNode ignores do not), so PHPStan fails with 34 errors. This cleanup belongs on the deps-bump branch, where the new rules make the ignores genuinely stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PHPStan currently reports 2 errors on
main:bin/rector.php:19-@ini_set('memory_limit', '-1')(intentional, marked// @ intentionally)src/Caching/ValueObject/Storage/FileCacheStorage.php:58-@var_export(...)(native filesystem call, needed for performance)Their
symplify.forbiddenNodeignores were dropped in #8566 as if stale, but the@usages are deliberate and still present, so the ignores are needed.Changes
symplify.forbiddenNodeignores forbin/rector.phpandFileCacheStorage.php.reportUnmatchedIgnoredErrors(remove thefalseoverride, PHPStan default istrue) so stale ignores are caught in CI going forward.symplify.*ignores it surfaced (noConstructorOverride,noDynamicName,noReference,noNullableServiceInConstructor,commandHasAsCommandAttribute) - those rules no longer fire on the listed paths.