From d216a48bb285e48af1eb77b289631153c592c28a Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sat, 10 Oct 2026 10:34:11 +0200 Subject: [PATCH] perf: single map lookup in ReplaceHttpServerVarsByServerRector --- .../ReplaceHttpServerVarsByServerRector.php | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/rules/Php53/Rector/Variable/ReplaceHttpServerVarsByServerRector.php b/rules/Php53/Rector/Variable/ReplaceHttpServerVarsByServerRector.php index 5e3eee9798a..d3a80b7f238 100644 --- a/rules/Php53/Rector/Variable/ReplaceHttpServerVarsByServerRector.php +++ b/rules/Php53/Rector/Variable/ReplaceHttpServerVarsByServerRector.php @@ -56,15 +56,16 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?Node { - foreach (self::VARIABLE_RENAME_MAP as $oldName => $newName) { - if (! $this->isName($node, $oldName)) { - continue; - } + $variableName = $this->getName($node); + if ($variableName === null) { + return null; + } - $node->name = $newName; - return $node; + if (! isset(self::VARIABLE_RENAME_MAP[$variableName])) { + return null; } - return null; + $node->name = self::VARIABLE_RENAME_MAP[$variableName]; + return $node; } }