Repository navigation
[perf] Skip scope fetch in TypeDeclaration return-type rules when return type already set or body empty - #8582
Merged
Merged
Conversation
…eclaration return-type rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Across the TypeDeclaration return-type family,
refactor()fetched the PHPStan scope as its first statement, then immediately checked$node->returnType instanceof Node/ emptystmts- directly or inside ashouldSkip()whose opening lines ignore the scope.Those node-only checks skip the overwhelming majority of inputs (any already-typed or empty-bodied method), so they now run before
ScopeFetcher::fetch(). Where the cheap checks lived insideshouldSkip(), they are moved up intorefactor()so the scope is pulled only once a candidate survives them.Rules touched:
Behavior is unchanged - same guards, earlier bail. Follows the same shape as #8579.