Repository navigation
Early downgrade RuleDoc classes in scoped build - #8592
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scoped build (which publishes rectorphp/rector) fails at the PHP 7.4 lint step:
The inlined
Rector\RuleDocclasses are registered as BC aliases fromsrc/functions/rule_doc_generator_class_aliases.php, which is a composerfilesautoload - so it runs on bootstrap and eagerly loads those classes. During the 7.4 phase of the scoped build the still-8.x source gets parsed and fatals. Previously these classes lived in thesymplify/rule-doc-generator-contractsvendor package and were never autoloaded eagerly.Same pattern already used for the other
filesautoload entry (node_helper.php): downgrade it early, under PHP 8.4, before the version switch. This extends that step tosrc/RuleDoc, so the class-alias bootstrap can load them under 7.4.