Repository navigation
[perf] Speed up ArrayExplicitBoolCompareRector with cheap variable guard - #8603
Merged
Merged
Conversation
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule ran costly native type resolution on every
If_/ElseIf_/Ternarynode, twice per node:ExplicitBoolConditionResolver::resolve()->getNativeType()ArrayTypeAnalyzer::isArrayType()->getNativeType()But the rule only ever rewrites a bare
Variablecondition (it bailed otherwise after both type calls already ran).getNativeType()is not cached and triggers scope resolution, so this was wasted work on the vast majority of conditions.Changes:
Variablestructural guard before any type resolution, so non-variable conditions bail instantly.getNativeType()calls into one. A confirmed array type already excludesmixedandbool, so the resolver's native type check was redundant here.ExplicitBoolConditionResolverdependency from this rule (still used byObjectExplicitBoolCompareRector).Behavior is unchanged - both fixtures still pass, and the skip fixture (a
PropertyFetchcondition) is now skipped with zero type resolution.