Repository navigation
[skipper] Merge UsedSkipCollector into Skipper as single service - #8604
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the
UsedSkipCollectorused-skip tracking intoSkipper, so there is a single skipper service instead of two.Skippernow owns theusedSkipsstate, with a privatemarkUsed()and a publicprovideUsedSkips().PathSkipper::shouldSkip()no longer marks skips used; it is renamed tomatchSkippedPath()and returns the matched path (or null).Skipper::shouldSkipFilePath()does the marking. This breaks theSkipper -> PathSkipper -> Skipperdependency cycle the merge would otherwise create.FilesFinderroutes path skips throughSkipper::shouldSkipFilePath()so finder-level path skips stay marked used.ApplicationFileProcessorreads used skips fromSkipperdirectly.UsedSkipCollectorTestis merged intoSkipperTest.