Skip to content

[skipper] Merge UsedSkipCollector into Skipper as single service - #8604

Merged
TomasVotruba merged 1 commit into
mainfrom
merge-usedskipcollector-into-skipper
Oct 10, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
merge-usedskipcollector-into-skipper

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Folds the UsedSkipCollector used-skip tracking into Skipper, so there is a single skipper service instead of two.

  • Skipper now owns the usedSkips state, with a private markUsed() and a public provideUsedSkips().
  • PathSkipper::shouldSkip() no longer marks skips used; it is renamed to matchSkippedPath() and returns the matched path (or null). Skipper::shouldSkipFilePath() does the marking. This breaks the Skipper -> PathSkipper -> Skipper dependency cycle the merge would otherwise create.
  • FilesFinder routes path skips through Skipper::shouldSkipFilePath() so finder-level path skips stay marked used.
  • ApplicationFileProcessor reads used skips from Skipper directly.
  • UsedSkipCollectorTest is merged into SkipperTest.

@TomasVotruba
TomasVotruba merged commit 095685a into main Oct 10, 2026
49 checks passed
@TomasVotruba
TomasVotruba deleted the merge-usedskipcollector-into-skipper branch October 10, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant