Repository navigation
Skip NullToStrictString arg already cast to target type - #8688
Merged
Merged
Conversation
Guard against nesting a redundant cast when the converter re-processes a value already cast or literal of the target type (or a ternary whose branches are). Structural check, immune to stale resolved types on re-printed nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
NullToStrictStringIntConverteridempotent: skip a value that is already a cast or literal of the target type (or a ternary whose both branches are), so re-processing does not nest a redundant(string)/(int)cast.The check is structural, so it also holds when the resolved type is stale on a re-printed node - the usual type-based skip relies on a fresh type and would miss it there.