Repository navigation
misc cleanup - #8793
Merged
Merged
misc cleanup#8793
Conversation
TomasVotruba
commented
Oct 23, 2026
TomasVotruba
commented
Member
- [perf] avoid checking instanceof stmt
- no need for first class callable
- tidy
- cleanup unused code
- remove deprecated and unused UseNodesToAddCollector
TomasVotruba
force-pushed
the
tv-traverse-scope-3
branch
from
October 26, 2026 08:14
168be14 to
99b3c6f
Compare
samsonasik
pushed a commit
that referenced
this pull request
Nov 5, 2026
…ateMethodParameterRector (#8923) * [NodeTypeResolver] Set scope on the class name of a first-class callable processCallLike() returned early for every first-class callable, which left the class name of self::method(...) and static::method(...) without a scope. NameTypeResolver needs that scope to resolve self and static, so it returned an ObjectType for a class literally named "self" or "static". RemoveUnusedPrivateMethodParameterRector could then not match the callable to its class, missed the isFirstClassCallable() guard and removed a parameter from a method whose arity the receiving code controls. The early return only has to protect getArgs(), so it moves back below the scope assignments, where it was before #8793. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [DeadCode] Skip private method used as array callable on removing unused parameter The code receiving [self::class, 'method'], [static::class, 'method'] or [$this, 'method'] decides how many arguments it passes, the same as with a first-class callable. PrivateMethodParamRemover never looked at arrays, so it removed the parameter. It now keeps the parameter when an array in the class names the method, or when ArrayCallableMethodMatcher cannot tell which method the array names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.