Remove NullToStrictStringIntConverter, use explicit null type in null-to-strict rules

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/null_defined_in_variable_first.php.inc

@@ -22,7 +22,7 @@ class NullDefinedInVariableFirst
     public function getTitle()
     {
         $title = null;
-        return trim((string) $title);
+        return trim('');
     }
 }
 

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_case_insensitive_function_name.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class CaseInsensitiveFunctionName
+{
+    public function run($var)
+    {
+        return strToLower($var);
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_crypt_one_arg.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+/**
+ * Crypt requires 2 args since php 5.6, when it only fill 1st arg, it will only change 1st arg
+ *
+ * Note: Filling 2nd arg will require different Rule to match the salt algorithm.
+ */
+final class CryptOneArg
+{
+    public function run($subject)
+    {
+        crypt($subject);
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_explicit_mixed_in_trait.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+trait ExplicitMixedInTrait
+{
+    public function setTitle(mixed $title)
+    {
+        $this->title = $title;
+        return trim($this->title);
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_named_argument.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class NamedArgument
+{
+    public function run($subject)
+    {
+        preg_split(subject: $subject, pattern: '#a#');
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_non_string_param_type.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class NonStringParamType
+{
+    public function run($subject)
+    {
+        preg_split('#a#', $subject);
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_non_string_param_type_in_use_closure.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class NonStringParamTypeInUseClosure
+{
+    public function run($subject)
+    {
+        function () use ($subject) {
+            preg_split('#a#', $subject);
+        };
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_normal_variable_in_trait.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+trait NormalVariableInTrait
+{
+    public function getTitle($title)
+    {
+        return trim($title);
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_ternary_with_ints.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class TernaryWithInts
+{
+    public function run($value)
+    {
+        explode(
+            ',',
+            (string) $value ? 100 : 500
+        );
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_with_existing_cast_on_ternary.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class WithExistingCastOnTernary
+{
+    public function run()
+    {
+        return $relpath
+            . '/' . rawurlencode((string) $this->Get('account_code') ?: $this->Get('customer_id'));
+    }
+
+    public function run2()
+    {
+        return $relpath
+            . '/' . rawurlencode((string) $this->Get('account_code') ?: null);
+    }
+
+    public function Get($fieldname)
+    {
+        return $this->{$fieldname} ?? null;
+    }
+}
+
+?>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_with_nullable_docblock.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+class WithNullableDocblock
+{
+   /**
+     * @var string|null
+     */
+    public $importedId;
+
+    /**
+     * @param string|null $importedId
+     */
+    public function setImportedId($importedId) {
+        if (strlen($this->importedId) > 0) {
+            $this->importedId = $importedId;
+        }
+    }
+}
+
+?>