Repository navigation
Deprecate PhpVersionFeature, use PhpVersion constants directly in rules - #8839
Merged
Merged
Conversation
This was referenced Oct 25, 2026
TomasVotruba
force-pushed
the
tv-deprecate-php-version-feature
branch
from
October 25, 2026 22:57
2f770af to
1a7ed79
Compare
TomasVotruba
force-pushed
the
tv-deprecate-php-version-feature
branch
from
October 25, 2026 22:59
1a7ed79 to
f0d4236
Compare
Member
Author
|
Instead of having hundreds of version constants for each RFC/feature, lets narrow to simple and clear PHP versions 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the recent move away from indirection layers (e.g. the
NullToStrictStringIntConverterremoval).PhpVersionFeaturewas a thin name map overPhpVersion- every constant was just an alias for aPhpVersion::PHP_XXint. This swaps all in-repo usages to the underlyingPhpVersion::*constants and marks the class@deprecated.src/,rules/,rules-tests/,tests/) now usePhpVersion::PHP_XXdirectly.PhpVersionFeatureis kept and marked@api+@deprecatedso sibling packages (symfony, doctrine, phpunit, downgrade-php) that still reference it keep working;@apikeeps the dead-code detector green while those are migrated.Green locally:
composer complete-check(ECS, PHPStan level 8, PHPUnit) andcomposer rector.