Repository navigation
[perf] Fork parallel workers from the main process when PHPStan Turbo is loaded - #8929
Open
samsonasik wants to merge 5 commits into
Open
samsonasik wants to merge 5 commits into
samsonasik wants to merge 5 commits into
Conversation
Member
Author
|
@TomasVotruba ready 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve parallel process performance by using
pcntl_forkwhen possible, as a forked worker is a copy of the already initialized PHP process, so it can start working right away, see my post at dev to that I applied the performance improvement onStructArmedviapcntl_forkwhen possible:https://dev.to/samsonasik/structarmed-fast-php-architecture-guards-you-can-rely-on-3be3#an-even-faster-parallel-process
Measured with
bench/parallel_memory_bench.php, 8 workers, 3 cold runs each, PHP 8.4, same php.ini with PHPStan Turbo loaded on both sides:systemsrcWithout PHPStan Turbo loaded in the main process, workers are still spawned and nothing changes.