From 1cee1a1a0478f470779d8ce9f13df457d3db8e89 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 16 Nov 2026 06:26:17 +0700 Subject: [PATCH 1/2] [Privatization] Fix invalid "private protected(set)" on asymmetric visibility property on PrivatizeFinalClassPropertyRector --- .../Privatization/NodeManipulator/VisibilityManipulator.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rules/Privatization/NodeManipulator/VisibilityManipulator.php b/rules/Privatization/NodeManipulator/VisibilityManipulator.php index 3d98728ac97..bbf31cac33f 100644 --- a/rules/Privatization/NodeManipulator/VisibilityManipulator.php +++ b/rules/Privatization/NodeManipulator/VisibilityManipulator.php @@ -116,6 +116,11 @@ public function makePrivate(ClassMethod|Property|ClassConst|Param $node): void { $this->replaceVisibilityFlag($node, Visibility::PRIVATE); + // private property cannot have wider set visibility, and private(set) is redundant + if ($node instanceof Property || $node instanceof Param) { + $node->flags &= ~Modifiers::VISIBILITY_SET_MASK; + } + // only constructor can be both private and final if ($node instanceof ClassMethod && $this->nodeNameResolver->isName($node, MethodName::CONSTRUCT)) { return; From dce1e293cfec8a7dc8aba8f01652109ba79ce20c Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 16 Nov 2026 06:26:32 +0700 Subject: [PATCH 2/2] fixture --- .../Fixture/asymmetric_visibility.php.inc | 35 +++++++++++++++++++ .../skip_public_asymmetric_visibility.php.inc | 15 ++++++++ 2 files changed, 50 insertions(+) create mode 100644 rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc create mode 100644 rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc diff --git a/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc new file mode 100644 index 00000000000..3e3af9ff872 --- /dev/null +++ b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc @@ -0,0 +1,35 @@ + +----- + diff --git a/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc new file mode 100644 index 00000000000..07a84d33a71 --- /dev/null +++ b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc @@ -0,0 +1,15 @@ +