From 9e19355974458d41600c83de1852fd15f7c73545 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Mon, 16 Nov 2026 17:59:01 +0100 Subject: [PATCH] [TypeDeclarationDocblocks] Remove 6 deprecated rules --- ...aramArrayDocblockBasedOnArrayMapRector.php | 69 -------------- ...ramArrayDocblockFromDataProviderRector.php | 88 ----------------- ...blockForDimFetchArrayFromAssignsRector.php | 89 ------------------ ...rnDocblockFromMethodCallDocblockRector.php | 94 ------------------- ...rayDocblockFromDataProviderParamRector.php | 83 ---------------- .../AddReturnDocblockDataProviderRector.php | 89 ------------------ 6 files changed, 512 deletions(-) delete mode 100644 rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockBasedOnArrayMapRector.php delete mode 100644 rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDataProviderRector.php delete mode 100644 rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php delete mode 100644 rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php delete mode 100644 rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnArrayDocblockFromDataProviderParamRector.php delete mode 100644 rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnDocblockDataProviderRector.php diff --git a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockBasedOnArrayMapRector.php b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockBasedOnArrayMapRector.php deleted file mode 100644 index 48c265e05f3..00000000000 --- a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockBasedOnArrayMapRector.php +++ /dev/null @@ -1,69 +0,0 @@ - trim($name), $names); - } -} -CODE_SAMPLE - , - <<<'CODE_SAMPLE' -final class SomeClass -{ - /** - * @param string[] $names - */ - public function run(array $names): void - { - $names = array_map(fn(string $name) => trim($name), $names); - } -} -CODE_SAMPLE - ), - ]); - } - - /** - * @return array> - */ - public function getNodeTypes(): array - { - return [ClassMethod::class, Function_::class]; - } - - /** - * @param ClassMethod|Function_ $node - */ - public function refactor(Node $node): ?Node - { - throw new ShouldNotHappenException(sprintf( - '"%s" rule is deprecated, as the param type guessed from a single array_map() closure is vague and unreliable. Add the @param docblock manually instead', - self::class - )); - } -} diff --git a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDataProviderRector.php b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDataProviderRector.php deleted file mode 100644 index 3234f646834..00000000000 --- a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDataProviderRector.php +++ /dev/null @@ -1,88 +0,0 @@ -> - */ - public function getNodeTypes(): array - { - return [Class_::class]; - } - - /** - * @param Class_ $node - */ - public function refactor(Node $node): ?Node - { - throw new ShouldNotHappenException(sprintf( - '"%s" is deprecated, as data provider docblock typing is not relevant to code quality', - self::class - )); - } -} diff --git a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php deleted file mode 100644 index 7a7c9d421cc..00000000000 --- a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php +++ /dev/null @@ -1,89 +0,0 @@ - - */ - public function toArray() - { - $items = []; - - if (mt_rand(0, 1)) { - $items['key'] = 'value'; - } - - if (mt_rand(0, 1)) { - $items['another_key'] = 'another_value'; - } - - return $items; - } -} -CODE_SAMPLE - ), - - ] - ); - } - - public function getNodeTypes(): array - { - return [ClassMethod::class]; - } - - /** - * @param ClassMethod $node - */ - public function refactor(Node $node): ?ClassMethod - { - throw new ShouldNotHappenException(sprintf( - '"%s" rule is deprecated, as the array shape guessed from conditional assigns is vague and unreliable. Add the @return docblock manually instead', - self::class - )); - } -} diff --git a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php deleted file mode 100644 index 64d94c72f56..00000000000 --- a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php +++ /dev/null @@ -1,94 +0,0 @@ -repository->findAll(); - } -} - -final class Repository -{ - /** - * @return SomeEntity[] - */ - public function findAll(): array - { - // ... - } -} -CODE_SAMPLE - , - <<<'CODE_SAMPLE' -final class SomeController -{ - /** - * @return SomeEntity[] - */ - public function getAll(): array - { - return $this->repository->findAll(); - } -} - -final class Repository -{ - /** - * @return SomeEntity[] - */ - public function findAll(): array - { - // ... - } -} -CODE_SAMPLE - ), - - ] - ); - } - - /** - * @return array> - */ - public function getNodeTypes(): array - { - return [ClassMethod::class]; - } - - /** - * @param ClassMethod $node - */ - public function refactor(Node $node): ?Node - { - throw new ShouldNotHappenException(sprintf( - '"%s" is deprecated, as it copies docblock from another method call that can be incorrect or outdated', - self::class - )); - } -} diff --git a/rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnArrayDocblockFromDataProviderParamRector.php b/rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnArrayDocblockFromDataProviderParamRector.php deleted file mode 100644 index 211363eef08..00000000000 --- a/rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnArrayDocblockFromDataProviderParamRector.php +++ /dev/null @@ -1,83 +0,0 @@ -> - */ - public function provideItems() - { - return [ - [['item1', 'item2']], - [['item3', 'item4']], - ]; - } -} -CODE_SAMPLE - ), - ]); - } - - /** - * @param Class_ $node - */ - public function refactor(Node $node): ?Node - { - throw new ShouldNotHappenException(sprintf( - '"%s" is deprecated, as data provider docblock typing is not relevant to code quality', - self::class - )); - } -}