Skip to content

Handle confirmation support for Inline refactorings - #4567

Merged
datho7561 merged 1 commit into
redhat-developer:mainfrom
shin19991207:fix-4425
Oct 30, 2026
Merged

datho7561 merged 1 commit into
redhat-developer:mainfrom
shin19991207:fix-4425

Conversation

@shin19991207

Copy link
Copy Markdown
Member

Fixes #4425

Handle JDT.LS confirmation requests before applying "inline" refactoring edits, which - Show the reported problems in a modal Continue/Cancel dialog.

  • Retry with the confirmation token only when the user selects Continue.
  • Leave files unchanged when the user cancels.

Also extract the existing "move" confirmation logic into a shared helper

Tested with eclipse-jdtls/eclipse.jdt.ls#3960

Signed-off-by: Morgan Chang <shin19991207@gmail.com>

@datho7561 datho7561 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Thanks, Morgan!

@datho7561
datho7561 merged commit 68044a5 into redhat-developer:main Oct 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Inline Method changes behavior for polymorphic method call

2 participants