Skip to content

Commit 377b6af

Browse files
Requiring non-empty relationship lists before checking labels.
1 parent 09b494a commit 377b6af

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

‎report/src/test/java/org/hjug/refactorfirst/report/JsonGeneratorTest.java‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -400,19 +400,15 @@ public ClassB(ClassA classA) {
400400
assertNotNull(report);
401401

402402
// Verify ClassRelationshipDTO renderedLabel contains HTML links
403-
if (report.getClassRelationshipsToRemove() != null
404-
&& report.getClassRelationshipsToRemove().getRelationships() != null
405-
&& !report.getClassRelationshipsToRemove().getRelationships().isEmpty()) {
406-
var classRel =
407-
report.getClassRelationshipsToRemove().getRelationships().get(0);
408-
assertNotNull(classRel.getRenderedLabel(), "ClassRelationshipDTO should have renderedLabel");
409-
// Only check for links if source path was available
410-
if (classRel.getRenderedLabel().contains("<a href=\"")) {
411-
assertTrue(
412-
classRel.getRenderedLabel().contains("target=\"_blank\""),
413-
"renderedLabel should have target=\"_blank\" attribute");
414-
}
415-
}
403+
assertNotNull(report.getClassRelationshipsToRemove());
404+
assertNotNull(report.getClassRelationshipsToRemove().getRelationships());
405+
assertFalse(report.getClassRelationshipsToRemove().getRelationships().isEmpty());
406+
var classRel = report.getClassRelationshipsToRemove().getRelationships().get(0);
407+
assertNotNull(classRel.getRenderedLabel(), "ClassRelationshipDTO should have renderedLabel");
408+
assertTrue(classRel.getRenderedLabel().contains("<a href=\""));
409+
assertTrue(
410+
classRel.getRenderedLabel().contains("target=\"_blank\""),
411+
"renderedLabel should have target=\"_blank\" attribute");
416412

417413
// Verify PackageRelationshipDTO renderedLabel contains HTML links
418414
if (report.getPackageRelationshipsToRemove() != null

0 commit comments

Comments
 (0)