Fix CodeRabbit issues in PR #208

Author: coderabbitai[bot]

report/src/main/java/org/hjug/refactorfirst/report/ReportWriter.java

@@ -111,8 +111,8 @@ private static final class SecureDirectoryOpsImpl implements SecureDirectoryOps
 
         @Override
         public void writeAtomically(Path reportName, String content) throws IOException {
-            SecureDirectoryStream<Path> current = openSecurePath();
             try {
+                SecureDirectoryStream<Path> current = openSecurePath();
                 writeAtomicallySecure(current, reportName, content);
             } finally {
                 closeDirectories(openedDirectories);
@@ -126,6 +126,9 @@ private SecureDirectoryStream<Path> openSecurePath() throws IOException {
             Path currentPath = startPath;
 
             for (Path component : startPath.relativize(outputDirectory)) {
+                if (component.toString().isEmpty()) {
+                    continue;
+                }
                 SecureDirectoryStream<Path> child;
                 try {
                     child = current.newDirectoryStream(component, NOFOLLOW_LINKS);
@@ -194,20 +197,18 @@ private static final class FallbackDirectoryOps implements SecureDirectoryOps {
 
         @Override
         public void writeAtomically(Path reportName, String content) throws IOException {
+            Path targetFile = outputDirectory.resolve(reportName);
+            rejectExistingSymbolicLinkComponents(targetFile);
+
             // Ensure parent directories exist
             Files.createDirectories(outputDirectory);
 
-            Path targetFile = outputDirectory.resolve(reportName);
-
             // Check if target exists and is a symlink or directory
             if (Files.exists(targetFile, NOFOLLOW_LINKS)) {
                 BasicFileAttributes attrs = Files.readAttributes(targetFile, BasicFileAttributes.class, NOFOLLOW_LINKS);
                 if (attrs.isSymbolicLink() || attrs.isDirectory()) {
                     throw new IOException("Refusing to replace non-regular report path: " + reportName);
                 }
-            } else {
-                // Verify no symlink in path components
-                rejectExistingSymbolicLinkComponents(targetFile);
             }
 
             // Write to temporary file then atomically move