fail loudly when the app package has no __init__.py by flcrom · Pull Request #7304 · reflex-dev/reflex

flcrom · 2026-09-24T10:11:59Z

The granian backend gets the app as a file path, and granian works out the module name by walking up through directories that have an __init__.py. When myapp/myapp/__init__.py is missing it imports the app as myapp instead of myapp.myapp. The compiler used myapp.myapp, so the root state names don't match and every delta gets dropped on the client.

get_app_file() now checks that each package in the app module path has an __init__.py and raises a clear error pointing at the missing file, instead of starting a backend that looks fine but never updates.

Tests cover the missing-init layouts (including a package-style app_module_import) and check that granian resolves the app file to the configured module name for valid layouts. Ran the unit suite, ruff, and pyright on the touched packages locally (full-repo pyright ran out of memory on my machine).

greptile-apps · 2026-09-24T10:15:29Z

Confidence Score: 4/5

[High impact] Changes how the backend app module is loaded and resolved.

The backend change appears safe, but the required test-function docstring should be added before merging.

Findings

Missing test docstring ▶

Summary

The PR switches Granian’s backend target from an app file path to the configured module name while retaining app-file validation. It adds regression tests for namespace-style app layouts, missing modules, and project-root imports.

_{Reviews (8) · Last reviewed commit: "Merge main into PR #7304 to refresh requ..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

codspeed · 2026-09-24T10:19:34Z

Merging this PR will not alter performance

✅ 150 untouched benchmarks
⏩ 18 skipped benchmarks¹

_{Comparing flcrom:fix/app-package-init-mismatch (f9000a3) with main (38a30fc)}

18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

flcrom · 2026-09-29T10:14:25Z

Updated this to create the missing __init__.py files before the backend import, while leaving existing files untouched. The regression tests cover nested packages, an app package, existing files, and an invalid marker path. Full unit suite, lint, and pyright pass locally. Could you take another look?

cubic-dev-ai

All reported issues were addressed across 3 files (changes from recent commits).

_{You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

FarhanAliRaza

I tested this PR with a small app. The app has a root state and a substate, and its app package has no __init__.py.

On the base commit, I reproduced #7258. Clicks did not update the page, and the browser console showed the no dispatch function for substate(s) error.

On this branch, the bug is fixed in dev mode and in prod mode. The backend created the missing __init__.py in the app source tree and did not log a message.

I then changed only the Granian target on the base commit to the module name. That change also fixed the bug, and it wrote no file. Hot reload and the existing tests still passed.

The requested change is in the inline comment.

cubic-dev-ai

All reported issues were addressed across 4 files (changes from recent commits).

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

#7304 ended up passing Granian the configured module target, so the original fragment was accurate. The start method variables are only read on the Granian code paths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW

#7646) * Correct 0.10.1 news fragments and document REFLEX_BACKEND_START_METHOD The 7258 fragment described the opposite of what #7304 does (it raises an error for a missing __init__.py instead of loading the app), the repeated headers fragment still claimed client_ip came from the first x-forwarded-for hop after #7614 made that depend on trusted_proxy_hops, and the 7261 fragment belonged to a docs-only change. Add the backend start method variables to the self-hosting docs; they were only described in environment.py. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW * Keep the 7258 fragment and scope the start method docs to Granian #7304 ended up passing Granian the configured module target, so the original fragment was accurate. The start method variables are only read on the Granian code paths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW --------- Co-authored-by: Claude <noreply@anthropic.com>

fail loudly when the app package has no __init__.py

331fd86

flcrom requested a review from a team as a code owner September 24, 2026 10:12

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread news/7258.bugfix.md Outdated

masenf reviewed Sep 28, 2026

View reviewed changes

Comment thread reflex/utils/exec.py Outdated

flcrom added 3 commits September 29, 2026 15:43

Create missing app package markers before backend import

aaaadd1

Test package marker creation and existing-file safety

52e4c15

Update bugfix note for automatic package markers

9ca06c0

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread news/7258.bugfix.md Outdated

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py Outdated

Comment thread reflex/utils/exec.py Outdated

Guard package marker creation for namespace and read-only apps

5387c2b

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py Outdated

Comment thread tests/units/utils/test_exec.py Outdated

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py Outdated

Preserve nested regular package imports

5708e9d

FarhanAliRaza reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py Outdated

FarhanAliRaza requested changes Sep 29, 2026

View reviewed changes

Use module target for Granian backend imports

6be6e9e

flcrom requested a review from FarhanAliRaza September 29, 2026 19:05

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py

Comment thread tests/units/utils/test_granian_module_target.py

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread reflex/utils/exec.py

Preserve app module validation for Granian target

5c74ee0

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread tests/units/utils/test_granian_module_target.py

Restore sys.path after missing-module test

daaa1db

FarhanAliRaza approved these changes Oct 5, 2026

View reviewed changes

Merge branch 'main' into fix/app-package-init-mismatch

ce65434

masenf added the bug Something isn't working label Oct 6, 2026

masenf added the on deck PRs lined up to review / merge next label Oct 9, 2026 — with ChatGPT Codex Connector

Merge main into PR reflex-dev#7304 to refresh required CI

f9000a3

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread tests/units/utils/test_granian_module_target.py

FarhanAliRaza approved these changes Oct 9, 2026

View reviewed changes

FarhanAliRaza merged commit 162e5ef into reflex-dev:main Oct 9, 2026
146 checks passed

masenf mentioned this pull request Oct 23, 2026

Correct 0.10.1 news fragments and document REFLEX_BACKEND_START_METHOD #7646

Merged

1 task done

Conversation

flcrom commented Sep 24, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

flcrom commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FarhanAliRaza left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

flcrom commented Sep 24, 2026 •

edited by cubic-dev-ai Bot

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

codspeed Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading