You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(vars): type LiteralObjectVar.create to take any value that serializes to a mapping - #7403
LiteralObjectVar.create annotated its value as Mapping, but takes anything that serializes to a mapping: a value that is not a mapping goes through serialize, and only a result that is not a mapping raises TypeError (its docstring says "a mapping type or a dataclass"). So pyright and ty rejected calls that work:
@dataclasses.dataclassclassPoint:
x: intLiteralObjectVar.create(Point(1)) # Argument of type "Point" cannot be assigned to parameter "_var_value" of type "Mapping[Unknown, Unknown]"
The value is now annotated object, which is what the method checks at runtime, and the docstring names what it takes. Runtime behaviour is unchanged.
tests/type_checking/vars.py makes that call; it fails under pyright and ty before this change. The full unit suite and pyright pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LiteralObjectVar.createannotated its value asMapping, but takes anything that serializes to a mapping: a value that is not a mapping goes throughserialize, and only a result that is not a mapping raisesTypeError(its docstring says "a mapping type or a dataclass"). So pyright and ty rejected calls that work:The value is now annotated
object, which is what the method checks at runtime, and the docstring names what it takes. Runtime behaviour is unchanged.tests/type_checking/vars.pymakes that call; it fails under pyright and ty before this change. The full unit suite and pyright pass.