Repository navigation
test(workflow): remove timing flake from rate-limit burst and refill test - #7433
Merged
Merged
Conversation
Contributor
|
Merging this PR will not alter performance
Comparing Footnotes
|
1 task done
FarhanAliRaza
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PostgreSQL workflow job failed because
test_a_rate_limit_lets_through_a_burst_then_refillsmeasured the fourth workflow start from before sequential database inserts and required it to happen within one second. CI took 1.127 seconds, so setup and worker scheduling could fail the test even when the rate limit behaved correctly.Check the real worker's completed counts after it settles: four workflows from the initial full bucket, then two more after each refill. Configure four tokens per hour for this test and backdate the exhausted bucket by half an hour to release two tokens without depending on wall-clock performance. Assert both recorded starts and committed row statuses at counts four, six, and eight.
Add normal and deliberately delayed setup cases. The 1.1-second delay reproduced the original failure before the fix; both cases now pass. This test-only change branches directly from
mainand is separate from the JSON output fix in #7428.Validation: