Skip to content

Fix primitive progress ARIA values - #7438

Merged
masenf merged 7 commits into
reflex-dev:mainfrom
harsh21234i:fix/7431-primitive-progress-aria
Oct 9, 2026
Merged

masenf merged 7 commits into
reflex-dev:mainfrom
harsh21234i:fix/7431-primitive-progress-aria

Conversation

@harsh21234i

@harsh21234i harsh21234i commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Forward value and max to the Radix Progress Root as well as the Indicator. The Root needs these props to report the current progress state and render the correct ARIA attributes.

Testing

  • Radix component unit tests: 9 passed.
  • Local Chrome check: confirmed aria-valuenow updates from 25 to 50 after a state change, with aria-valuemax="100".

Closes #7431.

Review in cubic

@harsh21234i
harsh21234i requested a review from a team as a code owner October 6, 2026 05:12
@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds progress value properties to the progress component root.

The PR appears safe to merge.

Summary

The PR forwards progress values to the Radix Root so its ARIA attributes reflect the displayed progress, and adds unit and Playwright coverage for those values and a state update.

Reviews (6) · Last reviewed commit: "Narrow progress components in unit test"

Comment thread tests/units/components/radix/test_primitive_progress.py

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@codspeed

codspeed Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 150 untouched benchmarks
⏩ 18 skipped benchmarks1


Comparing harsh21234i:fix/7431-primitive-progress-aria (36b603a) with main (e080fbf)

Open in CodSpeed

Footnotes

  1. 18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/integration/tests_playwright/test_radix_components.py Outdated
@masenf masenf added the bug Something isn't working label Oct 6, 2026
@masenf masenf added the on deck PRs lined up to review / merge next label Oct 9, 2026 — with ChatGPT Codex Connector
@masenf
masenf merged commit d8747f1 into reflex-dev:main Oct 9, 2026
154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working on deck PRs lined up to review / merge next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Primitive Progress wrapper omits numeric props from Root and ARIA value

2 participants