Repository navigation
Handle intentional Granian SIGTERM shutdown - #7457
harsh21234i wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
Merging this PR will improve performance by 8.74%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_hydration_metadata[200] |
2 ms | 1.8 ms | +8.74% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing harsh21234i:fix/7266-granian-sigterm-shutdown (d96e563) with main (8239259)
Footnotes
-
18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
FarhanAliRaza
left a comment
There was a problem hiding this comment.
this does not seem to fix the issue.
|
Closing in favor of #7538. In a full |
Closes #7266 by avoiding a misleading “Unexpected exit” error when Reflex and its Granian worker receive SIGTERM together.
The worker watcher treats SIGTERM as intentional only after Granian's supervisor has received its own interrupt signal. Worker-only SIGTERM exits retain Granian's normal failure handling and release the listener when no workers remain.
Testing
tests/units/utils/test_exec.py: 33 passed, 3 skippedgit diff --checkpassed