Repository navigation
fix: handle frontend error events without an Error object - #7544
Merged
Merged
Conversation
3 tasks done
Contributor
|
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7482.
window.onerrorreaderror.nameanderror.messageunconditionally. Some error events have noErrorobject, such as the benignResizeObserver loopnotification, so the handler threw and nothing reachedhandle_frontend_exception.When there is no
Errorobject, the handler now reports the message plusurl:line:columninstead. The existing path is unchanged when anErroris present.Added a test to
state_js.test.mjsfor the no-Errorcase (the existing setup gained areactoverride so the hook can be exercised).node --experimental-vm-modules --test tests/units/compiler/state_js.test.mjspasses locally, 19/19. I did not run the full test suite or lint locally; CI will.News fragment included.
All Submissions:
Type of change