Repository navigation
fix: sync every storage var that shares a name across tabs - #7545
Merged
FarhanAliRaza merged 2 commits intoOct 15, 2026
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryCross-tab storage updates now sync every
Reviews (4) · Last reviewed commit: "Merge branch 'main' into fix-storage-syn..." · Reviewed by Greptile |
Merging this PR will not alter performance
|
flcrom
force-pushed
the
fix-storage-sync-shared-name
branch
from
October 11, 2026 05:28
40bfe59 to
21bc00e
Compare
masenf
reviewed
Oct 14, 2026
masenf
left a comment
Collaborator
There was a problem hiding this comment.
looks good. rebase on main now that your other PR has merged
flcrom
force-pushed
the
fix-storage-sync-shared-name
branch
from
October 14, 2026 08:28
21bc00e to
f88486b
Compare
Contributor
Author
|
Rebased onto main (f88486b). |
FarhanAliRaza
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7506.
Builds on #7544. The first commit in this branch is that PR's commit (9870bf1), because the new test uses the
reactoverride that #7544 adds to thestate_js.test.mjssetup. Only the second commit (40bfe59) is new here. I'll rebase onto main once #7544 merges, or happy to restructure if you prefer.When several
sync=Truestorage vars share one storagename, a write in another tab updated only one of them (the last declared), so the others stayed stale until a reload. The common case is a named synced field on anrx.ComponentStateused more than once. The cross-tab sync now updates every var that shares the name.Added tests to
state_js.test.mjsfor the shared-name case.node --experimental-vm-modules --test tests/units/compiler/state_js.test.mjspasses locally, 21/21. I did not run the full test suite or lint locally; CI will.News fragment included.
All Submissions:
Type of change