Skip to content

Install plotly for the playground in the benchmark CI jobs - #7557

Merged
FarhanAliRaza merged 1 commit into
reflex-dev:mainfrom
FarhanAliRaza:farhan/bench-plotly
Oct 13, 2026
Merged

FarhanAliRaza merged 1 commit into
reflex-dev:mainfrom
FarhanAliRaza:farhan/bench-plotly

Conversation

@FarhanAliRaza

@FarhanAliRaza FarhanAliRaza commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The benchmark CI jobs install the workspace with uv sync --no-dev --group bench --extra db. Since #7359, the playground imports plotly, which that install does not contain. So every benchmark that compiles the playground has failed since 2026-10-07 with ModuleNotFoundError: No module named 'plotly':

  • benchmarks-daily: red every day since 2026-10-07. The browser, events, hmr and memory shards fail completely. Lifecycle (9 of 12) and exact (8 of 13) fail partly.
  • macro-benchmarks: green, but 6 of its 7 benchmarks fail. Only lifecycle.import passes. The job exits 0 while one benchmark passes.

This PR adds plotly>=6.0,<7.0 to the bench dependency group. It uses the same range as examples/playground/pyproject.toml. Subjects built with --reflex already get plotly through SUBJECT_REQUIREMENTS.

Checked locally with the CI install (uv sync --no-dev --group bench --extra db in a fresh venv):

  • with this change: reflex-bench run lifecycle.compile.warm gives ok · 3 samples;
  • after uv pip uninstall plotly: failed, with ModuleNotFoundError: No module named 'plotly', the same error as CI.

The change touches only a dependency group and the lock file. It is not user-facing, so it needs skip-changelog.

View guided diff

The playground imports plotly since reflex-dev#7359, but the benchmark jobs install the workspace with only the bench group and the db extra. Every benchmark that compiles the playground has failed with ModuleNotFoundError since 2026-10-07.
@FarhanAliRaza
FarhanAliRaza requested a review from a team as a code owner October 13, 2026 19:17
@FarhanAliRaza FarhanAliRaza added the skip-changelog For doc/internal changes label Oct 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:21:50.683145Z ab2c65e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Re-trigger cubic

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab2c65eded

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge and supplies the missing Plotly dependency to benchmark CI.

Summary

Adds plotly>=6.0,<7.0 to the bench dependency group so workspace benchmarks can compile the playground.

  • Benchmark installs now include Plotly for compiling the playground.

Reviews (1) · Last reviewed commit: "Install the playground's plotly dependen..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 14 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 148 untouched benchmarks


Comparing FarhanAliRaza:farhan/bench-plotly (ab2c65e) with main (2640303)

Open in CodSpeed

@FarhanAliRaza
FarhanAliRaza merged commit 54ab4d9 into reflex-dev:main Oct 13, 2026
148 of 149 checks passed
@FarhanAliRaza
FarhanAliRaza deleted the farhan/bench-plotly branch October 13, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants