Repository navigation
Install plotly for the playground in the benchmark CI jobs - #7557
Conversation
The playground imports plotly since reflex-dev#7359, but the benchmark jobs install the workspace with only the bench group and the db extra. Every benchmark that compiles the playground has failed with ModuleNotFoundError since 2026-10-07.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab2c65eded
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merging this PR will not alter performance
|
The benchmark CI jobs install the workspace with
uv sync --no-dev --group bench --extra db. Since #7359, the playground importsplotly, which that install does not contain. So every benchmark that compiles the playground has failed since 2026-10-07 withModuleNotFoundError: No module named 'plotly':benchmarks-daily: red every day since 2026-10-07. The browser, events, hmr and memory shards fail completely. Lifecycle (9 of 12) and exact (8 of 13) fail partly.macro-benchmarks: green, but 6 of its 7 benchmarks fail. Onlylifecycle.importpasses. The job exits 0 while one benchmark passes.This PR adds
plotly>=6.0,<7.0to thebenchdependency group. It uses the same range asexamples/playground/pyproject.toml. Subjects built with--reflexalready get plotly throughSUBJECT_REQUIREMENTS.Checked locally with the CI install (
uv sync --no-dev --group bench --extra dbin a fresh venv):reflex-bench run lifecycle.compile.warmgivesok · 3 samples;uv pip uninstall plotly:failed, withModuleNotFoundError: No module named 'plotly', the same error as CI.The change touches only a dependency group and the lock file. It is not user-facing, so it needs
skip-changelog.