Repository navigation
Forward POSIX shutdown signals to supervised processes in JSON mode - #7558
harsh21234i wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
[High impact] The PR appears safe to merge; the previous terminal quit issue is fixed. SummaryOn POSIX,
Reviews (6) · Last reviewed commit: "fix: forward SIGQUIT to supervised proce..." · Reviewed by Greptile |
Merging this PR will not alter performance
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Summary
When
reflex run --jsonsupervises a child process, a SIGINT sent to the supervisor PID can interrupt the supervisor without stopping the child. Forward SIGINT to the running child on POSIX so process supervisors configured withstopsignal=INTcan stop Reflex cleanly.Closes #7509.
Testing
uv run pytest tests/units/reflex_base/utils/test_log.py -q— 80 passed, 2 skipped on Windows.