Repository navigation
fix: avoid npm reinstall for empty devDependencies - #7566
harsh21234i wants to merge 4 commits into
Conversation
[Medium impact] The PR appears safe to merge. SummaryTreats missing and empty
Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." · Reviewed by Greptile |
Merging this PR will improve performance by 4.12%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_route_argument_extraction |
119.7 µs | 114.9 µs | +4.12% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing harsh21234i:fix/7480-npm-manifest-normalization (f35ef79) with main (7ccaa4e)
# Conflicts: # .github/workflows/examples.yml
Summary
devDependenciesfield and an empty object as equivalent when comparing rendered package manifests.Fixes #7480
Tests
uv run pytest tests/units/utils/test_frontend_skeleton.py tests/units/utils/test_js_runtimes.py -q(24 passed)REFLEX_USE_NPM=1: a Python source-only hot reload rebuilt the app without rerunning npm install.