Repository navigation
ENG-13348: Fix Contact Sales dialog scrolling on mobile - #7576
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryKeeps the Contact Sales dialog within the mobile viewport.
The earlier, unnumbered finding about missing browser coverage is addressed by the scrolling test. No new actionable issues were found in the changes since the previous review. Reviews (3) · Last reviewed commit: "Re-register dialog icons for each browse..." · Reviewed by Greptile |
Merging this PR will improve performance by 4.45%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_route_argument_extraction |
119.7 µs | 114.6 µs | +4.45% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing carlos/eng-13348-contact-sales-mobile (b195be5) with main (7ccaa4e)
Uh oh!
There was an error while loading. Please reload this page.