Skip to content

ENG-13348: Fix Contact Sales dialog scrolling on mobile - #7576

Merged
carlosabadia merged 3 commits into
mainfrom
carlos/eng-13348-contact-sales-mobile
Oct 15, 2026
Merged

carlosabadia merged 3 commits into
mainfrom
carlos/eng-13348-contact-sales-mobile

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

View guided diff Turn on auto-fix

@carlosabadia
carlosabadia requested a review from a team as a code owner October 15, 2026 09:29
@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown

ENG-13348

@carlosabadia carlosabadia changed the title Fix Contact Sales dialog scrolling on mobile (ENG-13348) ENG-13348: Fix Contact Sales dialog scrolling on mobile Oct 15, 2026
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Oct 15, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Keeps the Contact Sales dialog within the mobile viewport.

  • Contact Sales fields scroll while the dialog header and Submit stay visible.

The earlier, unnumbered finding about missing browser coverage is addressed by the scrolling test. No new actionable issues were found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "Re-register dialog icons for each browse..." · Reviewed by Greptile

Comment thread tests/units/reflex_components_internal/blocks/test_demo_form.py Outdated
@codspeed

codspeed Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 4.45%

⚠️ 20 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚡ 1 improved benchmark
✅ 147 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_route_argument_extraction 119.7 µs 114.6 µs +4.45%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing carlos/eng-13348-contact-sales-mobile (b195be5) with main (7ccaa4e)

Open in CodSpeed

FarhanAliRaza
FarhanAliRaza previously approved these changes Oct 15, 2026
@carlosabadia
carlosabadia merged commit ce534da into main Oct 15, 2026
144 checks passed
@carlosabadia
carlosabadia deleted the carlos/eng-13348-contact-sales-mobile branch October 15, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants