Repository navigation
feat: expose react-moment 2 configuration - #7591
harsh21234i wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
[Medium impact] The PR appears safe to merge; the previous duplication finding is fixed, and no new actionable issues were found. SummaryAdds more
The previous duplication finding is fixed. No new actionable issues were found. Reviews (5) · Last reviewed commit: "fix: share Moment locale import handling" · Reviewed by Greptile |
Merging this PR will degrade performance by 4.07%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_state_access[write_own] |
126.1 ms | 131.4 ms | -4.07% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing harsh21234i:fix/7100-moment-props (7a5aa7f) with main (5ae5dcd)
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Summary
rx.moment.rx.moment_providerfor shared defaults and pooled timers.filterprop and the reportedsettingsandform_atinputs.Closes #7100
Tests
git diff --checkpassed.