Skip to content

Remove white top edge from XY docs banner - #531

Merged
carlosabadia merged 1 commit into
mainfrom
carlos/xy-banner-top-edge
Oct 15, 2026
Merged

carlosabadia merged 1 commit into
mainfrom
carlos/xy-banner-top-edge

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The XY docs announcement still drew a 1px white line along its top edge. Remove the inset shadow from the banner’s glass overlay and record the intended treatment in the docs specification.

Validation: production build passed. Inspected the banner at 1440px, 390px, and 320px; browser checks confirmed no top shadow or border, no horizontal overflow, and working keyboard focus and reduced-motion behavior. The three docs layout tests and the required repository hooks, Ruff lint, and formatting checks passed.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Style
    • Removed the white top-edge shadow from the announcement banner.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 83f7e1d5-7db4-4e53-bbba-7857afa12730
📥 Commits

Reviewing files that changed from the base of the PR and between 973cca6 and 553a013.

📒 Files selected for processing: 2
  • docs/app/assets/docs-header-theme.css
  • spec/process/production-readiness.md
💤 Files with no reviewable changes: 1
  • docs/app/assets/docs-header-theme.css

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The announcement banner no longer has an inset white top-edge shadow. The production-readiness specification now records that the opal banner artwork has no such shadow.

Changes: Announcement banner appearance

Layer / File(s) Summary
Banner styling and specification
docs/app/assets/docs-header-theme.css, spec/process/production-readiness.md
The CSS removes the inset white top-edge shadow from the banner overlay. The production-readiness specification records that the opal artwork has no such shadow.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: alek99

Merge Risk: ⚪ Minimal · up to 553a0

The banner loses its white top-edge inset shadow while retaining its artwork and gradients. The documented treatment matches, and no actionable merge risk remains.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the white top edge from the XY docs banner.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Removes the white top-edge inset shadow from the docs announcement’s glass overlay.

  • The docs announcement banner no longer has a white line along its top edge.

Reviews (1) · Last reviewed commit: "Remove white top edge from XY docs annou..." · Reviewed by Greptile

@carlosabadia
carlosabadia merged commit 7a75a98 into main Oct 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant