Deprecate dropdown - #356
Open
lpsmith wants to merge 1 commit into
Open
Conversation
Contributor
Author
lpsmith
force-pushed
the
ls-deprecate-dropdown
branch
from
January 10, 2020 16:03
b14b7cf to
a56ba01
Compare
ryantrinkle
self-requested a review
January 14, 2020 16:31
ryantrinkle
requested changes
Jan 14, 2020
ryantrinkle
left a comment
ryantrinkle
left a comment
Member
There was a problem hiding this comment.
It's not enough to just deprecate it; we need to give people a suitable alternative.
Member
|
In this case, I think what we need to do is write up an example of how to use selectElement that we can link people to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the current plan of (eventually) moving the high-level widgets to their own library, we might also consider deprecating most of the module, especially: