fix: prevent docs pageview replay after uncertain delivery

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>

Author: jeremi

docs/site/scripts/shared-tracking.test.mjs

@@ -112,12 +112,6 @@ test('tracking controls use the shared bridge and remain available after failure
   assert.match(component, /main Registry Stack website and this\s+documentation/i);
   assert.match(component, /data-tracking-error[^>]*role="alert"/);
   assert.match(component, /client\.pageview\(pageview\)/);
-  assert.match(component, /let sentGeneration: string \| null = null/);
-  assert.match(component, /let pendingGeneration: string \| null = null/);
-  assert.match(component, /state\.generation === sentGeneration/);
-  assert.match(component, /state\.generation === pendingGeneration/);
-  assert.match(component, /sentGeneration = state\.generation/);
-  assert.match(component, /currentState\.generation === state\.generation/);
   assert.match(component, /addEventListener\('pagehide', \(event\) => \{/);
   assert.match(component, /if \(!event\.persisted\) trackingClient\.close\(\)/);
   assert.doesNotMatch(component, /location\.reload/);

docs/site/src/components/RegistryTrackingPreferences.astro

@@ -68,9 +68,8 @@ const { canonicalOrigin, privacyUrl } = Astro.props;
       ? new URL(window.location.pathname, canonicalOrigin).toString()
       : undefined;
     const browserDeniesTracking = trackingDeniedByBrowser();
-    let sentGeneration: string | null = null;
-    let pendingGeneration: string | null = null;
-    let currentState: TrackingState | null = null;
+    // Retain attempts after ambiguous delivery so recovery cannot count a visit twice.
+    let attemptedGeneration: string | null = null;
     let client: ReturnType<typeof createSharedTrackingClient> | undefined;
 
     const showPanel = () => {
@@ -96,7 +95,6 @@ const { canonicalOrigin, privacyUrl } = Astro.props;
         errorMessage.hidden = true;
         delete errorMessage.dataset.trackingFailure;
       }
-      currentState = state;
       if (state.choice === null) {
         showPanel();
         return;
@@ -111,36 +109,27 @@ const { canonicalOrigin, privacyUrl } = Astro.props;
       if (
         state.choice !== 'accepted' ||
         !state.generation ||
-        state.generation === sentGeneration ||
-        state.generation === pendingGeneration ||
+        state.generation === attemptedGeneration ||
         !client
       )
         return;
 
-      pendingGeneration = state.generation;
       try {
         const pageview = buildMauticPageview({
           canonicalUrl,
           currentUrl: window.location.href,
           pageTitle: document.title,
           referrer: document.referrer,
         });
+        attemptedGeneration = state.generation;
         await client.pageview(pageview);
-        if (
-          currentState?.choice === 'accepted' &&
-          currentState.generation === state.generation
-        ) {
-          sentGeneration = state.generation;
-        }
       } catch (error) {
         if (
           client.state.choice === 'accepted' &&
           client.state.generation === state.generation
         ) {
           showFailure(error);
         }
-      } finally {
-        if (pendingGeneration === state.generation) pendingGeneration = null;
       }
     };