Skip to content

fix: keep docs consent controls above the sidebar - #2421

Merged
jeremi merged 1 commit into
mainfrom
codex/docs-consent-overlay
Oct 24, 2026
Merged

jeremi merged 1 commit into
mainfrom
codex/docs-consent-overlay

Conversation

@jeremi

@jeremi jeremi commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Summary

Keep the docs cookie preference controls clickable on wide screens. The fixed panel was inside Starlight's isolated main pane, allowing the right sidebar to intercept clicks on Reject at 1488px and 1536px.

Move the existing hidden panel to the document body before initializing its controls so it can appear above the sidebar.

Evidence

  • Reproduced with the actual docs build: mouse clicks failed at 1488px and 1536px; 1280px and keyboard activation worked.
  • The companion browser regression checks the actual mouse target and clicks Reject at all three widths.
  • Chromium, Firefox and WebKit pass the full shared tracking journey against the corrected /dev/ build.
  • The local /dev/ build passes. CI passes the full docs script tests and production-shaped build.
  • Independent code review found no blockers.
  • Local full-suite limitation: an existing tutorial fixture stalls with Bash 5.3.9. Retrying with system Bash 3.2 passes 895 of 896 tests; the remaining fixture requires BASHPID, which Bash 3.2 lacks. The tutorial harness is unchanged.

Notes

Tracking remains optional. This does not change visitor identity, form submission, scoring or automated email behavior. Immutable released docsets remain unchanged.

DCO

  • Every commit includes a Signed-off-by trailer.
  • I reviewed the submitted changes and take responsibility for them.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T19:05:37.658678Z ef6d2f9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremi
jeremi added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit 20c6e34 Oct 24, 2026
54 checks passed
@jeremi
jeremi deleted the codex/docs-consent-overlay branch October 24, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant