Repository navigation
fix: unblock multi-flow registries and expose workflow refusals - #2433
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
A role change re-applies the active package, whose schema fingerprint an earlier release measured with the 1,024-statement ledger constraint. Widening that constraint during the role change made the measured catalog differ from the declared one and failed the activation. A fresh ledger now carries the 4,096-statement constraint from creation, and only a successor to a different package widens a legacy one. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Realistic reviewed registries could pass authoring checks and then fail candidate preparation at a hidden migration ceiling. Candidate failures also discarded their cause, while dev-session log filtering and concealed inbox source refusals left operators without useful diagnostics.
--deny-warningsenforces it without rejecting valid baseline-derived successor plans.test.candidate.refused, adding the value-free package error variant and failing stage at all four call sites.bregctl devwhile retaining stdout/stderr capture.Closes #2427
Closes #2428
Closes #2429
Closes #2430
Closes #2431
Refs #2432
Evidence
Focused checks use a disposable PostgreSQL/PostGIS database.
Protected CI passed for the submitted revision, including all selected Rust, PostgreSQL 18, native-binding, contract, configuration, catalog and documentation jobs. CodeQL also passed with no new alerts in the changed code.
cargo test --locked -p registry-breg --features postgres-test,tooling,schema --test postgres_package: the 66 existing cases passed. The two added capacity cases initially exposed the manifest-size ceiling; after fixing it, both passed in a focused rerun. They activate initial and reviewed successor packages above 1,024 statements, including rehearsal rollback and a legacy ledger constraint. The strengthened legacy case also measures the old constraint's actual fingerprint, forces a precondition failure after maintenance begins, and successfully retries the exact pinned target on PostgreSQL 18.cargo test --locked -p registry-breg --features postgres-test,tooling,schema --test postgres_multi_reference_action_authority: passed. Signed tokens traverse the authenticator and router; north-only and south-only claims independently refuse the opposite reference, and omitted/empty preconditions replay one receipt.cargo test --locked -p registry-breg --features postgres-test,tooling,schema --test problem_code_catalogues --test postgres_proposal_review_delivery: 5 and 40 passed, including the existing terminal-refusal warning/redaction regression.-D warnings: all targets for the three owning crates without optional PostgreSQL test features passed; all changed PostgreSQL/HTTP targets with those features also passed.cargo fmt --all -- --checkandgit diff --checkpassed.bregctl dev starton a fresh copy ofproducts/breg/fixtures/multi-reference-array-claim, using both binaries rebuilt from the final committed source, exited successfully withok: trueandstatus: ready. Its maintained journeys run before the service becomes ready.Notes
The ledger upgrade runs within the existing migration-authorized transaction. On legacy databases, its constraint change commits when maintenance begins and remains after later failure; recovery uses the exact target or the pre-activation backup, as documented in the operator lifecycle. Statement, manifest, per-file and total-package bounds remain explicit; oversized manifests are refused before publication creates an output directory. Operator summaries contain fixed failure classes, without task counts, identities, tokens, profile values or provider error strings.
The remaining #2432 enhancement, identifying a stale input in a 412 response, is deferred. Persisted handoff refusal details and cross-project doctor checks are also deferred.
Verification limits: the broad optional-PostgreSQL all-target Clippy invocation encounters an unchanged unused helper in
postgres_native_retention; the changed database targets pass separately. Global Vale and shfmt report existing findings outside the edited prose and unchanged shell formatting. Protected CI supplies the broader regression coverage and is green for this revision; no merge or release is performed here.DCO
Signed-off-bytrailer.