Repository navigation
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 793b770a04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60f9c58684
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cwd.and_then(|cwd| within_project(cwd.join(path))) | ||
| .or_else(|| within_project(root.join(path))) |
There was a problem hiding this comment.
When a check receives --project /path/to/project --runtime-config runtime.yaml from outside the project, and both the working directory and project contain runtime.yaml, this fallback assigns warnings from the external runtime file to the project's file. For example, Messaging's runtime_report preserves the CLI-relative source name, so an external platform.runtime-config.check-incomplete warning can inherit an acceptance authored for the project's runtime file and incorrectly pass --deny-warnings. Preserve the source-path context or normalize explicit runtime sources before matching; an existing external source must not be reinterpreted as a different project file. This violates the exact project-file scope required by CFG-DIAG-7 in the normative configuration conventions.
AGENTS.md reference: AGENTS.md:L131-L133
Useful? React with 👍 / 👎.
Project checks now read optional
check-acceptances.yamlentries containing an exact warning code, source scope, and required reason. Accepted warnings stay visible with their reasons and do not fail--deny-warnings; errors remain blocking. Acceptances persist until edited or removed, with no fingerprints, expiry, or automatic reapproval.The shared implementation covers BReg, Evidence, Casework, Scheduling, Messaging, Coordinator, Document Store, Discovery, Manifest, and Render. It includes schema and editor support, configuration documentation, and regressions for malformed files, error non-acceptance, source scoping, and combined project/runtime reports.
Validation:
Security review: this changes advisory reporting only. Runtime authorization and validation are unchanged. Negative tests confirm that acceptance cannot suppress errors, match another resource, import an external symlink, or omit its reason.