Repository navigation
fix: preserve BReg Proposal authority through application - #2438
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 25, 2026
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require current executor authority and the exact retained submission task grant for every new BReg Proposal application. Recheck status before Review or Evidence access, validate the binding inside the mutation transaction, and enforce expiry through the final commit fence. Preserve completed receipt recovery and cancellation.
Require a usable inspection and cancellation permission path when activating a successor package with pending Proposals. Expand access explanations and keep target warnings, bounded refusal diagnostics, contract inventories and security traceability consistent with those checks.
Evidence
The integrated candidate passed all 12 PostgreSQL authority/recovery tests against PostgreSQL 18, plus the full CLI suites (612 library, 179 CLI and 28 explanation tests) and 107 Python/webhook contract tests. Strict Clippy, Cargo formatting, validators, shellcheck and secret scanning passed. The shell formatter reports the same existing two-space style differences as the source branch.
The merge queue caught a stale copied access-report excerpt. A fresh reader run reproduced the failure; after adding the observed actor, requester-client and task-grant lines, all seven access-page excerpts passed. The corresponding eSignet explanation block exactly matched a fresh offline compiled-access report. That eSignet check did not execute an OIDC issuer, provider or live sign-in journey. Content, Markdown, style and tutorial dry-run checks passed.
The final published head of #2394 passed protected CI. This replacement requires fresh protected CI and merge-queue checks before landing. Environment-dependent native and TLS journeys were not rerun locally.
Notes
Supersedes #2394 on a linear branch based on main, preserving its reviewed feature delta. The changelog integration retains main's diagnostics entries and the Proposal fixes. The original published branch remains intact.
There is no database migration or wire-format change. Remote revocation after status observation cannot be atomic with a local PostgreSQL commit; local grant expiry is enforced.
DCO
Signed-off-bytrailer.