Skip to content

feat: persist scoped project warning acceptances - #2444

Merged
jeremi merged 2 commits into
mainfrom
fix/project-check-acceptances-merge-20261026
Oct 26, 2026
Merged

jeremi merged 2 commits into
mainfrom
fix/project-check-acceptances-merge-20261026

Conversation

@jeremi

@jeremi jeremi commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Project checks can retain a deliberate acceptance of one warning, identified by its exact code and source scope, with a required reason. Accepted warnings remain visible in human and JSON output and do not fail --deny-warnings; errors remain blocking.

The shared format covers BReg, Evidence, Casework, Scheduling, Messaging, Coordinator, Document Store, Discovery, Manifest and Render. It includes strict schemas, editor bindings, configuration guidance and source-boundary tests. Acceptances persist until edited or removed.

Preserve accepted warnings alongside mixed project/runtime findings and later target or provider domain refusals. Existing diagnostic codes, scalar redaction and operational exit classes are retained. The API connection-report schema and identifier catalog are regenerated together, with the connections configuration contract unchanged.

Validation:

  • Shared API: 24 tests; Messaging CLI: 127 tests; BReg CLI: 181 command tests and 28 explanation tests.
  • Evidence and Casework: targeted pre-fix failures, post-fix regressions and package checks, including real late-validation paths. Evidence: 866 passed, 12 existing ignores. Casework: eight focused project tests passed, including namespace and contract refusal cases plus typed-report deduplication and operational-error preservation.
  • Identifier tests and full reproduction, 31 editor tests, strict Clippy, Cargo formatting and secret scanning passed.
  • Evidence production tutorial: the exact offline production-assurance refusal matches the maintained transcript. Content, Markdown, style, tutorial dry-run and three production-doc tests passed. Full issuer-backed journeys require fresh CI.
  • Fresh protected CI and merge-queue validation are required before landing. Local checks did not repeat PostgreSQL or running-service journeys for these offline reporting changes.

Supersedes #2434 on a linear branch based on current main. The original published branch remains intact.

DCO

  • Every commit includes a Signed-off-by trailer.
  • I reviewed the submitted changes and am responsible for the contribution.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T00:47:28.889964Z 7bff819 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jeremi
jeremi added this pull request to the merge queue Oct 26, 2026
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi removed this pull request from the merge queue due to a manual request Oct 26, 2026
@jeremi
jeremi added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit a0bee93 Oct 26, 2026
69 checks passed
@jeremi
jeremi deleted the fix/project-check-acceptances-merge-20261026 branch October 26, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant