Repository navigation
feat: persist scoped project warning acceptances - #2444
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project checks can retain a deliberate acceptance of one warning, identified by its exact code and source scope, with a required reason. Accepted warnings remain visible in human and JSON output and do not fail
--deny-warnings; errors remain blocking.The shared format covers BReg, Evidence, Casework, Scheduling, Messaging, Coordinator, Document Store, Discovery, Manifest and Render. It includes strict schemas, editor bindings, configuration guidance and source-boundary tests. Acceptances persist until edited or removed.
Preserve accepted warnings alongside mixed project/runtime findings and later target or provider domain refusals. Existing diagnostic codes, scalar redaction and operational exit classes are retained. The API connection-report schema and identifier catalog are regenerated together, with the connections configuration contract unchanged.
Validation:
Supersedes #2434 on a linear branch based on current main. The original published branch remains intact.
DCO
Signed-off-bytrailer.