Repository navigation
feat(evidence): report each definition's validitySeconds in explain - #2463
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
force-pushed
the
feat/evidence-explain-validity
branch
from
October 28, 2026 03:52
d1ec2f0 to
e398fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evidencectl explainJSON now reports each assertion definition'svaliditySecondsbeside itsrepresentationsandsubjectBinding. A tool that checks credential lifetimes against a deployment policy (for example, a cap on credentials issued without status) can read the value from explain without compiling the project or parsingevidence.yaml. Owning area: Evidence (crates/registry-evidencectl).The value is the definition's own
validitySeconds, which the authored project requires, so every definition carries it and nothing is defaulted. It is not added toauthority.effectiveCeilingsor the compiled ceilings: those feedeffectiveGrantDigestand the authority revision, and a lifetime is not a grant ceiling.Evidence
explain_json_reports_each_definitions_validity_seconds(crates/registry-evidencectl/tests/explain_sources.rs) copies the standalone example, sets the first definition to 900 seconds and asserts 900 for it and 300 for the rest. It failed before the change.cargo test -p registry-evidencectl --locked: all pass, 0 failed.cargo clippy -p registry-evidencectl --all-targets --locked -- -D warnings: clean.cargo fmt --check: clean.Notes
Additive field; the report
apiVersion(evidence/ctl-report/v1alpha1) is unchanged.credentialStatusis not part of this change. No migration. Can merge before or after 0.44.0.DCO
Signed-off-bytrailer.